[ 
https://issues.apache.org/jira/browse/BEAM-14294?focusedWorklogId=763944&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763944
 ]

ASF GitHub Bot logged work on BEAM-14294:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Apr/22 00:29
            Start Date: 29/Apr/22 00:29
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on PR #17384:
URL: https://github.com/apache/beam/pull/17384#issuecomment-1112774127

   @robertwb I think this is largely ready. I added a new `WindowedBatch` 
implementation, `HomogeneousWindowedBatch` which is effectively a wrapper 
around `WindowedValue`, where we know the value is a batch. We now enforce that 
batches are partitioned by `(timestamp, windows, pane_info)` and only create 
`HomoegeneousWindowedBatch` instances.
   
   The old implementation, `ConcreteWindowedBatch` isn't used, it's probably 
worth just backing that out and saving it for a future PR.
   
   Other notes: I've added support for {Timestamp, PaneInfo, Window}Param on 
process_batch (and we validate only these are used at construction time). Other 
DoFn params that were discussed in https://s.apache.org/batched-dofns are not 
yet supported.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 763944)
    Time Spent: 1h  (was: 50m)

> MVP for SDK worker changes to support process_batch
> ---------------------------------------------------
>
>                 Key: BEAM-14294
>                 URL: https://issues.apache.org/jira/browse/BEAM-14294
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: P2
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> The initial MVP may only work in some restricted circumstances (e.g. 
> @yields_element on process_batch, or batch-to-batch without a 1:1 
> input:output mapping might not be supported). These cases should fail early. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to