[
https://issues.apache.org/jira/browse/BEAM-14294?focusedWorklogId=765224&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765224
]
ASF GitHub Bot logged work on BEAM-14294:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/22 00:02
Start Date: 03/May/22 00:02
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on code in PR #17384:
URL: https://github.com/apache/beam/pull/17384#discussion_r863268400
##########
sdks/python/apache_beam/transforms/combiners.py:
##########
@@ -88,7 +90,7 @@ def expand(self, pcoll):
# TODO(laolu): This type signature is overly restrictive. This should be
# more general.
-@with_input_types(Union[float, int])
+@with_input_types(Union[float, int, np.int64, np.float64])
Review Comment:
Note I had to make this typehint change so I could use CombinePerKey in one
of my tests. Is this alright?
Issue Time Tracking
-------------------
Worklog Id: (was: 765224)
Time Spent: 2.5h (was: 2h 20m)
> MVP for SDK worker changes to support process_batch
> ---------------------------------------------------
>
> Key: BEAM-14294
> URL: https://issues.apache.org/jira/browse/BEAM-14294
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The initial MVP may only work in some restricted circumstances (e.g.
> @yields_element on process_batch, or batch-to-batch without a 1:1
> input:output mapping might not be supported). These cases should fail early.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
