[
https://issues.apache.org/jira/browse/BEAM-14239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530132#comment-17530132
]
Steve Niemitz commented on BEAM-14239:
--------------------------------------
#1 doesn't work if you have multiple timers set for different output times
right? If I set a timer to output at 10:00 and another at 10:05, both would
output at 10:05 if they used the watermark hold.
I agree changing windmill to support this directly is probably the best option,
rather than trying to work around it.
Does deleting the timer actually work in this case? I'd have to look at the
code, how does it know what the old output timestamp was in order to generate
the key?
> Changing the output timestamp of a timer does not clear the previously set
> timer
> --------------------------------------------------------------------------------
>
> Key: BEAM-14239
> URL: https://issues.apache.org/jira/browse/BEAM-14239
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Affects Versions: 2.37.0
> Reporter: Steve Niemitz
> Priority: P1
> Attachments: image-2022-04-04-09-57-29-583.png
>
>
> While looking into an unrelated bug with GroupIntoBatches, I noticed that it
> seems like changing the output timestamp of a timer does not clear the
> existing timer, and instead creates a new one.
> This kind of makes sense looking at the implementation of timers in Dataflow,
> the output timestamp is encoded into the timer ID, but this is not reflected
> in the timerStillPresent map in WindmillTimerInternals. It seems like it
> should be, and the previous timer should be deleted.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
