[ 
https://issues.apache.org/jira/browse/BEAM-14239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531977#comment-17531977
 ] 

Reuven Lax commented on BEAM-14239:
-----------------------------------

I've added the ability to store small amounts of metadata (64kb) per timer to 
Dataflow. Once this is released, I'll submit a PR to change 
WindmillTimerInternals to store the output timestamp in the metadata instead of 
the tagk

> Changing the output timestamp of a timer does not clear the previously set 
> timer
> --------------------------------------------------------------------------------
>
>                 Key: BEAM-14239
>                 URL: https://issues.apache.org/jira/browse/BEAM-14239
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>    Affects Versions: 2.37.0
>            Reporter: Steve Niemitz
>            Priority: P1
>         Attachments: image-2022-04-04-09-57-29-583.png
>
>
> While looking into an unrelated bug with GroupIntoBatches, I noticed that it 
> seems like changing the output timestamp of a timer does not clear the 
> existing timer, and instead creates a new one.  
> This kind of makes sense looking at the implementation of timers in Dataflow, 
> the output timestamp is encoded into the timer ID, but this is not reflected 
> in the timerStillPresent map in WindmillTimerInternals.  It seems like it 
> should be, and the previous timer should be deleted.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to