[
https://issues.apache.org/jira/browse/BEAM-14433?focusedWorklogId=767313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-767313
]
ASF GitHub Bot logged work on BEAM-14433:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/22 16:56
Start Date: 06/May/22 16:56
Worklog Time Spent: 10m
Work Description: lostluck opened a new pull request, #17575:
URL: https://github.com/apache/beam/pull/17575
This change improves the error message when a channel split fails with the
full split state and avoids a performance issue WRT listing all the split
indices in the error message as the string conversion is expensive.
Instead of listing all splits, since we've already sorted them all, we
simply list the count and the first and last split indices. This gives us
enough information to see what happened to cause the failure, which the current
message lacks. The length and first and last would let a debugger determine if
the range was complete or not.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 767313)
Remaining Estimate: 0h
Time Spent: 10m
> Make split failure message more concise.
> ----------------------------------------
>
> Key: BEAM-14433
> URL: https://issues.apache.org/jira/browse/BEAM-14433
> Project: Beam
> Issue Type: Wish
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Include the existing "split index" and not just the current processing index
> in the datasource.go split failure message.
> We also probably shouldn't print *all* the provided split indices as it's
> likely unnecessary work. The first and last and how many indices there are
> should be fine.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
