[
https://issues.apache.org/jira/browse/BEAM-14433?focusedWorklogId=768048&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-768048
]
ASF GitHub Bot logged work on BEAM-14433:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/22 17:20
Start Date: 09/May/22 17:20
Worklog Time Spent: 10m
Work Description: lostluck commented on code in PR #17575:
URL: https://github.com/apache/beam/pull/17575#discussion_r868241287
##########
sdks/go/pkg/beam/core/runtime/exec/datasource.go:
##########
@@ -596,8 +596,12 @@ func splitHelper(
if bestS != -1 {
return bestS, -1.0, nil
}
-
- return -1, -1.0, fmt.Errorf("failed to split DataSource (at index: %v)
at requested splits: {%v}", currIdx, splits)
+ // Printing all splits is expensive. Instead, return the current start
and
+ // end indices, and fraction along with the range of the indices and how
+ // many there are. This branch requires least one split index, so we
don't
Review Comment:
Good catch! applied!
Issue Time Tracking
-------------------
Worklog Id: (was: 768048)
Time Spent: 1h 10m (was: 1h)
> Make split failure message more concise.
> ----------------------------------------
>
> Key: BEAM-14433
> URL: https://issues.apache.org/jira/browse/BEAM-14433
> Project: Beam
> Issue Type: Wish
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Include the existing "split index" and not just the current processing index
> in the datasource.go split failure message.
> We also probably shouldn't print *all* the provided split indices as it's
> likely unnecessary work. The first and last and how many indices there are
> should be fine.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
