[
https://issues.apache.org/jira/browse/BEAM-14374?focusedWorklogId=767459&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-767459
]
ASF GitHub Bot logged work on BEAM-14374:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/22 23:24
Start Date: 06/May/22 23:24
Worklog Time Spent: 10m
Work Description: robertwb commented on code in PR #17482:
URL: https://github.com/apache/beam/pull/17482#discussion_r867263904
##########
sdks/python/apache_beam/transforms/fully_qualified_named_transform_test.py:
##########
@@ -116,6 +119,14 @@ def test_glob_filter(self):
with self.assertRaises(ValueError):
FullyQualifiedNamedTransform._resolve('apache_beam.Row')
+ @patch('importlib.import_module')
+ def test_resolve(self, mock_import_module):
Review Comment:
Sorry to be a stickler, but this mocking doesn't actually convince me that
the code in question actually does the right thing. Could you actually perform
an import here so that we know we're interacting with the import module in the
right way?
Issue Time Tracking
-------------------
Worklog Id: (was: 767459)
Time Spent: 50m (was: 40m)
> Fix module import error in FullyQualifiedNamedTransform
> -------------------------------------------------------
>
> Key: BEAM-14374
> URL: https://issues.apache.org/jira/browse/BEAM-14374
> Project: Beam
> Issue Type: Bug
> Components: cross-language, sdk-py-core
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Fix module import error in FullyQualifiedNamedTransform
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
