[ 
https://issues.apache.org/jira/browse/BEAM-14374?focusedWorklogId=767473&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-767473
 ]

ASF GitHub Bot logged work on BEAM-14374:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/May/22 00:49
            Start Date: 07/May/22 00:49
    Worklog Time Spent: 10m 
      Work Description: ihji commented on code in PR #17482:
URL: https://github.com/apache/beam/pull/17482#discussion_r867279084


##########
sdks/python/apache_beam/transforms/fully_qualified_named_transform_test.py:
##########
@@ -116,6 +119,14 @@ def test_glob_filter(self):
       with self.assertRaises(ValueError):
         FullyQualifiedNamedTransform._resolve('apache_beam.Row')
 
+  @patch('importlib.import_module')
+  def test_resolve(self, mock_import_module):

Review Comment:
   Other tests already cover some real importing but I added two more that 
would have failed without the change in this PR.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 767473)
    Time Spent: 1h  (was: 50m)

> Fix module import error in FullyQualifiedNamedTransform
> -------------------------------------------------------
>
>                 Key: BEAM-14374
>                 URL: https://issues.apache.org/jira/browse/BEAM-14374
>             Project: Beam
>          Issue Type: Bug
>          Components: cross-language, sdk-py-core
>            Reporter: Heejong Lee
>            Assignee: Heejong Lee
>            Priority: P2
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Fix module import error in FullyQualifiedNamedTransform



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to