[
https://issues.apache.org/jira/browse/BEAM-14014?focusedWorklogId=768514&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-768514
]
ASF GitHub Bot logged work on BEAM-14014:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/22 13:48
Start Date: 10/May/22 13:48
Worklog Time Spent: 10m
Work Description: ryanthompson591 commented on code in PR #17244:
URL: https://github.com/apache/beam/pull/17244#discussion_r869262839
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient.py:
##########
@@ -557,6 +558,8 @@ def __init__(self, options, root_staging_location=None):
if self.google_cloud_options.no_auth:
credentials = None
else:
+ set_impersonation_accounts(
+ self.google_cloud_options.impersonate_service_account)
Review Comment:
yes, I found a point where the pipeline options are modified for job
submission and modified it so that impersonation doesn't propegate to the
workers.
For anyone unfamiliar looking at this comment, the service worker that runs
jobs in dataflow is unique and we don't want to try to do impersonation on the
service worker, but rather only on the submission to dataflow.
Issue Time Tracking
-------------------
Worklog Id: (was: 768514)
Time Spent: 4h (was: 3h 50m)
> Support impersonation credentials in Dataflow runner.
> -----------------------------------------------------
>
> Key: BEAM-14014
> URL: https://issues.apache.org/jira/browse/BEAM-14014
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Valentyn Tymofieiev
> Assignee: Ryan Thompson
> Priority: P2
> Time Spent: 4h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
