[
https://issues.apache.org/jira/browse/BEAM-14014?focusedWorklogId=769214&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769214
]
ASF GitHub Bot logged work on BEAM-14014:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/22 17:43
Start Date: 11/May/22 17:43
Worklog Time Spent: 10m
Work Description: tvalentyn commented on code in PR #17244:
URL: https://github.com/apache/beam/pull/17244#discussion_r870588294
##########
sdks/python/apache_beam/io/gcp/gcsio.py:
##########
@@ -156,10 +157,10 @@ class GcsIOError(IOError, retry.PermanentException):
class GcsIO(object):
"""Google Cloud Storage I/O client."""
- def __init__(self, storage_client=None):
+ def __init__(self, storage_client=None, pipeline_options={}): # pylint:
disable=dangerous-default-value
if storage_client is None:
storage_client = storage.StorageV1(
- credentials=auth.get_service_credentials(),
+ credentials=auth.get_service_credentials(pipeline_options),
Review Comment:
Will credentials singleton ever be created here during job submission path?
Does it make sense to define `def
get_service_credentials(pipeline_options=None):` so that you only need to pass
the options in the runners (DataflowRunner, Interactive Runner, etc), but don't
have to modify the IO code that instantiates an already created credentials, or
executes after job submission?
Issue Time Tracking
-------------------
Worklog Id: (was: 769214)
Time Spent: 5h (was: 4h 50m)
> Support impersonation credentials in Dataflow runner.
> -----------------------------------------------------
>
> Key: BEAM-14014
> URL: https://issues.apache.org/jira/browse/BEAM-14014
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Valentyn Tymofieiev
> Assignee: Ryan Thompson
> Priority: P2
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
