[
https://issues.apache.org/jira/browse/BEAM-14334?focusedWorklogId=769053&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769053
]
ASF GitHub Bot logged work on BEAM-14334:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/22 12:56
Start Date: 11/May/22 12:56
Worklog Time Spent: 10m
Work Description: echauchot commented on code in PR #17406:
URL: https://github.com/apache/beam/pull/17406#discussion_r870268151
##########
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkContextFactory.java:
##########
@@ -36,7 +36,8 @@ public final class SparkContextFactory {
* context will be reused for beam pipelines. This property should only be
enabled for tests.
*
* @deprecated Please use {@link SparkContextOptions} instead to allow for
proper lifecycle
Review Comment:
IMHO I think we should guide the user more by saying something like:
"Please use SparkContextRule to allow for automatic control of the
SparkContext lifecycle (with a default of reusing it) or directly provide a
SparkContext by using SparkContextFactory#setProvidedSparkContext and enabling
SparkContextOptions#usesProvidedSparkContext"
Issue Time Tracking
-------------------
Worklog Id: (was: 769053)
Time Spent: 7h 20m (was: 7h 10m)
> Avoid using forkEvery in Spark runner tests
> -------------------------------------------
>
> Key: BEAM-14334
> URL: https://issues.apache.org/jira/browse/BEAM-14334
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark, testing
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P2
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> Usage of *{color:#FF0000}forkEvery 1{color}* is typically a strong sign of
> poor quality / bad code and should be avoided:
> * It significantly impacts performance when running tests.
> * And it often hides resource leaks, either in code or worse in the runner
> itself.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
