[
https://issues.apache.org/jira/browse/BEAM-14334?focusedWorklogId=769526&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769526
]
ASF GitHub Bot logged work on BEAM-14334:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/22 10:29
Start Date: 12/May/22 10:29
Worklog Time Spent: 10m
Work Description: echauchot commented on code in PR #17406:
URL: https://github.com/apache/beam/pull/17406#discussion_r871218678
##########
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkContextFactory.java:
##########
@@ -36,7 +36,8 @@ public final class SparkContextFactory {
* context will be reused for beam pipelines. This property should only be
enabled for tests.
*
* @deprecated Please use {@link SparkContextOptions} instead to allow for
proper lifecycle
Review Comment:
when I said user, I meant user of the library in other words a beam dev.
Issue Time Tracking
-------------------
Worklog Id: (was: 769526)
Time Spent: 7h 50m (was: 7h 40m)
> Avoid using forkEvery in Spark runner tests
> -------------------------------------------
>
> Key: BEAM-14334
> URL: https://issues.apache.org/jira/browse/BEAM-14334
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark, testing
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P2
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> Usage of *{color:#FF0000}forkEvery 1{color}* is typically a strong sign of
> poor quality / bad code and should be avoided:
> * It significantly impacts performance when running tests.
> * And it often hides resource leaks, either in code or worse in the runner
> itself.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
