[
https://issues.apache.org/jira/browse/BEAM-14430?focusedWorklogId=769784&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769784
]
ASF GitHub Bot logged work on BEAM-14430:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/22 17:53
Start Date: 12/May/22 17:53
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on code in PR #17608:
URL: https://github.com/apache/beam/pull/17608#discussion_r871661762
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -1094,6 +1094,13 @@ message StandardCoders {
}
}
+message LogicalTypes {
Review Comment:
Yeah I'd be in favor of that. A couple of other suggestions:
- I think it would make sense to move this enum to schema.proto with all the
other representations for the type system
- This should document the representation type, argument type, and the
meaning of the logical type, as we do in the comment you linked.
Issue Time Tracking
-------------------
Worklog Id: (was: 769784)
Time Spent: 2h 20m (was: 2h 10m)
> Adding a logical type support for Python callables to Row schema
> ----------------------------------------------------------------
>
> Key: BEAM-14430
> URL: https://issues.apache.org/jira/browse/BEAM-14430
> Project: Beam
> Issue Type: New Feature
> Components: cross-language
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Adding a logical type support for Python callables to Row schema
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
