[
https://issues.apache.org/jira/browse/BEAM-14430?focusedWorklogId=769938&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769938
]
ASF GitHub Bot logged work on BEAM-14430:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/22 22:30
Start Date: 12/May/22 22:30
Worklog Time Spent: 10m
Work Description: ihji commented on code in PR #17608:
URL: https://github.com/apache/beam/pull/17608#discussion_r871856891
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema.proto:
##########
@@ -110,6 +112,27 @@ message LogicalType {
FieldValue argument = 5;
}
+// Universally defined Logical types for Row schemas.
+// These logical types are supposed to be understood by all SDKs.
+message LogicalTypes {
+ enum Enum {
+ // A URN for Python Callable logical type
+ // - Representation type: STRING
+ // - Language type: In Python SDK, PythonCallableWithSource.
+ // In any other SDKs, a wrapper object for a string which
+ // can be evaluated to a Python Callable object.
+ PYTHON_CALLABLE = 0 [(org.apache.beam.model.pipeline.v1.beam_urn) =
+ "beam:logical_type:python_callable:v1"];
+
+ // A URN for MicrosInstant type
+ // - Representation type: ROW<seconds: INT64, micros: INT64>
+ // - A timestamp without a timezone where seconds + micros represents the
+ // amount of time since the epoch.
Review Comment:
For now, python_callable and micros_instant are only two logical types
implemented in both Java and Python SDKs. schema logical type is implemented in
Java SDK but not in Python SDK. There're also a bunch of other logical types
only available to Java SDKs. Do you think we should add those to schema.proto
too?
Issue Time Tracking
-------------------
Worklog Id: (was: 769938)
Time Spent: 3h 40m (was: 3.5h)
> Adding a logical type support for Python callables to Row schema
> ----------------------------------------------------------------
>
> Key: BEAM-14430
> URL: https://issues.apache.org/jira/browse/BEAM-14430
> Project: Beam
> Issue Type: New Feature
> Components: cross-language
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Adding a logical type support for Python callables to Row schema
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
