[
https://issues.apache.org/jira/browse/BEAM-14347?focusedWorklogId=769871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769871
]
ASF GitHub Bot logged work on BEAM-14347:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/22 20:03
Start Date: 12/May/22 20:03
Worklog Time Spent: 10m
Work Description: lostluck commented on code in PR #17635:
URL: https://github.com/apache/beam/pull/17635#discussion_r871700297
##########
sdks/go/examples/snippets/04transforms.go:
##########
@@ -185,6 +190,8 @@ func formatCoGBKResults(key string, emailIter, phoneIter
func(*string) bool) str
func init() {
beam.RegisterFunction(formatCoGBKResults)
Review Comment:
This reveals we may want to also have a series of `register.FuncDoFn` for
func DoFns, which should be very similar but much much simpler than the struct
ones.
##########
sdks/go/examples/snippets/04transforms.go:
##########
@@ -185,6 +190,8 @@ func formatCoGBKResults(key string, emailIter, phoneIter
func(*string) bool) str
func init() {
beam.RegisterFunction(formatCoGBKResults)
Review Comment:
Whoops missed publishing these before you closed it.
WRT documentation changes, we likely do want to hold on making the beam
package GoDoc mention these until we're unblocked from the import process.
But the other example code (everything in beam/examples) and integration
test code can certainly make use of it before then. Doesn't need to be all at
once, we can divide it amongst the team so folks can get used to it.
Issue Time Tracking
-------------------
Worklog Id: (was: 769871)
Time Spent: 19h 10m (was: 19h)
> [Go SDK] Allow users to optimize DoFns with a single generic registration
> function
> ----------------------------------------------------------------------------------
>
> Key: BEAM-14347
> URL: https://issues.apache.org/jira/browse/BEAM-14347
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
> Reporter: Danny McCormick
> Assignee: Danny McCormick
> Priority: P2
> Time Spent: 19h 10m
> Remaining Estimate: 0h
>
> Right now, to optimize DoFn execution, users have to use the code generator.
> This updates to allow them to use generics instead.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
