[
https://issues.apache.org/jira/browse/BEAM-14014?focusedWorklogId=770294&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-770294
]
ASF GitHub Bot logged work on BEAM-14014:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/22 17:25
Start Date: 13/May/22 17:25
Worklog Time Spent: 10m
Work Description: tvalentyn commented on code in PR #17244:
URL: https://github.com/apache/beam/pull/17244#discussion_r872622468
##########
sdks/python/apache_beam/internal/gcp/auth.py:
##########
@@ -59,16 +73,19 @@ def set_running_in_gce(worker_executing_project):
executing_project = worker_executing_project
-def get_service_credentials():
+def get_service_credentials(pipeline_options):
"""For internal use only; no backwards-compatibility guarantees.
Get credentials to access Google services.
+ Args:
+ pipeline_options: Pipeline options, used in creating credentials
Review Comment:
I'd say something here like:
Pipeline options. Required on initial credential initialization when the
impersonate_service_account option is provided, otherwise passing `None` is
acceptable.
You can do it in a follow up change
Issue Time Tracking
-------------------
Worklog Id: (was: 770294)
Time Spent: 7h 20m (was: 7h 10m)
> Support impersonation credentials in Dataflow runner.
> -----------------------------------------------------
>
> Key: BEAM-14014
> URL: https://issues.apache.org/jira/browse/BEAM-14014
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Valentyn Tymofieiev
> Assignee: Ryan Thompson
> Priority: P2
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
