[
https://issues.apache.org/jira/browse/BEAM-14014?focusedWorklogId=777876&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777876
]
ASF GitHub Bot logged work on BEAM-14014:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/22 23:42
Start Date: 02/Jun/22 23:42
Worklog Time Spent: 10m
Work Description: lukecwik commented on code in PR #17394:
URL: https://github.com/apache/beam/pull/17394#discussion_r888490254
##########
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcpOptions.java:
##########
@@ -169,6 +169,25 @@ public interface GcpOptions extends GoogleApiDebugOptions,
PipelineOptions {
void setGcpCredential(Credentials value);
+ /**
+ * All API requests will be made as the given service account or target
service account in an
+ * impersonation delegation chain instead of the currently selected account.
You can specify
+ * either a single service account as the impersonator, or a comma-separated
list of service
+ * accounts to create an impersonation delegation chain.
+ */
+ @Description(
+ "All API requests will be made as the given service account or"
+ + " target service account in an impersonation delegation chain"
+ + " instead of the currently selected account. You can specify"
+ + " either a single service account as the impersonator, or a"
+ + " comma-separated list of service accounts to create an"
+ + " impersonation delegation chain.")
+ @JsonIgnore
+ @Nullable
+ String getImpersonateServiceAccount();
+
+ void setImpersonateServiceAccount(String impersonateServiceAccount);
Review Comment:
It seems odd to take a string that we parse instead of List<String>/String[]
since PipelineOptionsFactory can do this already for us. See
https://github.com/apache/beam/blob/937e22ffcb56c0722b558e7c5c1c30fda5116be8/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java#L1423
Issue Time Tracking
-------------------
Worklog Id: (was: 777876)
Time Spent: 8h 50m (was: 8h 40m)
> Support impersonation credentials in Dataflow runner.
> -----------------------------------------------------
>
> Key: BEAM-14014
> URL: https://issues.apache.org/jira/browse/BEAM-14014
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Valentyn Tymofieiev
> Assignee: Ryan Thompson
> Priority: P2
> Fix For: 2.40.0
>
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
