[ 
https://issues.apache.org/jira/browse/BEAM-14440?focusedWorklogId=770651&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-770651
 ]

ASF GitHub Bot logged work on BEAM-14440:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/May/22 03:28
            Start Date: 16/May/22 03:28
    Worklog Time Spent: 10m 
      Work Description: youngoli commented on code in PR #17587:
URL: https://github.com/apache/beam/pull/17587#discussion_r873298230


##########
sdks/go/pkg/beam/core/graph/coder/stringutf8_test.go:
##########
@@ -120,3 +120,26 @@ func TestEncodeDecodeStringUTF8LP(t *testing.T) {
                })
        }
 }
+
+func FuzzEncodeDecodeStringUTF8LP(f *testing.F) {

Review Comment:
   What is the reasoning behind ignoring encoding failures in the fuzz tests 
instead of just failing them? If that small change was made there's no reason 
we couldn't replace the existing tests, right?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 770651)
    Time Spent: 2h 20m  (was: 2h 10m)

> Add coder fuzz tests to the Go SDK
> ----------------------------------
>
>                 Key: BEAM-14440
>                 URL: https://issues.apache.org/jira/browse/BEAM-14440
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Jack McCluskey
>            Assignee: Jack McCluskey
>            Priority: P3
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> With the Go SDK now on minimum Go version 1.18, fuzz tests can be added to 
> the test corpus. The coder package is a good place to start with this, as we 
> handle primitives that can be directly generated by Go's native fuzz testing 
> and can check that we are getting the same values out after encoding and 
> decoding. 
>  
> An overview of potential fuzz testing in the Beam Go SDK can be found here: 
> https://docs.google.com/document/d/1VHe5xFHjsmgOj2upH2k4zT90S5SCPtGYSJNcvPj5fig/edit?usp=sharing



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to