[
https://issues.apache.org/jira/browse/BEAM-14440?focusedWorklogId=771071&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771071
]
ASF GitHub Bot logged work on BEAM-14440:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/22 00:06
Start Date: 17/May/22 00:06
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17587:
URL: https://github.com/apache/beam/pull/17587#discussion_r874249658
##########
sdks/go/pkg/beam/core/graph/coder/bytes_test.go:
##########
@@ -59,3 +59,23 @@ func TestEncodeDecodeBytes(t *testing.T) {
})
}
}
+
+func FuzzEncodeDecodeBytes(f *testing.F) {
Review Comment:
IIRC testing with the fuzz flag is not guaranteed to ever terminate. I tried
testing this out and its been running `FuzzEncodeDecodeBytes` for several
minutes.
It also seemed like `go test -fuzz ./...` didn't actually correctly run the
fuzz tests, it seems like they may need to be run one at a time:
```
dannymccormick-macbookpro:coder dannymccormick$ go test -fuzz ./...
testing: will not fuzz, -fuzz matches more than one fuzz test:
[FuzzEncodeDecodeBytes FuzzEncodeDecodeDouble FuzzEncodeDecodeUInt64
FuzzEncodeDecodeInt32 FuzzEncodeDecodeStringUTF8LP]
```
Issue Time Tracking
-------------------
Worklog Id: (was: 771071)
Time Spent: 3.5h (was: 3h 20m)
> Add coder fuzz tests to the Go SDK
> ----------------------------------
>
> Key: BEAM-14440
> URL: https://issues.apache.org/jira/browse/BEAM-14440
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P3
> Fix For: 2.40.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> With the Go SDK now on minimum Go version 1.18, fuzz tests can be added to
> the test corpus. The coder package is a good place to start with this, as we
> handle primitives that can be directly generated by Go's native fuzz testing
> and can check that we are getting the same values out after encoding and
> decoding.
>
> An overview of potential fuzz testing in the Beam Go SDK can be found here:
> https://docs.google.com/document/d/1VHe5xFHjsmgOj2upH2k4zT90S5SCPtGYSJNcvPj5fig/edit?usp=sharing
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
