[ 
https://issues.apache.org/jira/browse/BEAM-14481?focusedWorklogId=771567&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771567
 ]

ASF GitHub Bot logged work on BEAM-14481:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/May/22 20:33
            Start Date: 17/May/22 20:33
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] commented on PR #17693:
URL: https://github.com/apache/beam/pull/17693#issuecomment-1129291592

   # 
[Codecov](https://codecov.io/gh/apache/beam/pull/17693?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#17693](https://codecov.io/gh/apache/beam/pull/17693?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (2cf91fe) into 
[master](https://codecov.io/gh/apache/beam/commit/6774b747ba42fdc187d4ba8dc34f48a3e1cc9368?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (6774b74) will **decrease** coverage by `0.06%`.
   > The diff coverage is `96.34%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #17693      +/-   ##
   ==========================================
   - Coverage   74.00%   73.93%   -0.07%     
   ==========================================
     Files         695      695              
     Lines       91798    91516     -282     
   ==========================================
   - Hits        67934    67666     -268     
   + Misses      22616    22602      -14     
     Partials     1248     1248              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `83.70% <96.34%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/17693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ks/python/apache\_beam/runners/worker/opcounters.py](https://codecov.io/gh/apache/beam/pull/17693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvb3Bjb3VudGVycy5weQ==)
 | `84.17% <0.00%> (-0.66%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/typehints/batch.py](https://codecov.io/gh/apache/beam/pull/17693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL2JhdGNoLnB5)
 | `82.83% <ø> (-3.40%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/17693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=)
 | `90.27% <96.66%> (+2.32%)` | :arrow_up: |
   | 
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/17693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
 | `93.51% <100.00%> (+0.08%)` | :arrow_up: |
   | 
[...ks/python/apache\_beam/runners/worker/operations.py](https://codecov.io/gh/apache/beam/pull/17693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvb3BlcmF0aW9ucy5weQ==)
 | `70.01% <100.00%> (-4.08%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/17693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=)
 | `93.42% <100.00%> (-0.02%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/utils/windowed\_value.py](https://codecov.io/gh/apache/beam/pull/17693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvd2luZG93ZWRfdmFsdWUucHk=)
 | `92.20% <100.00%> (-0.14%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/internal/gcp/auth.py](https://codecov.io/gh/apache/beam/pull/17693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvZ2NwL2F1dGgucHk=)
 | `73.33% <0.00%> (-5.34%)` | :arrow_down: |
   | 
[.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/17693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5)
 | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
   | ... and [8 
more](https://codecov.io/gh/apache/beam/pull/17693/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/17693?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/17693?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[6774b74...2cf91fe](https://codecov.io/gh/apache/beam/pull/17693?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 771567)
    Time Spent: 0.5h  (was: 20m)

> OOM regression caused by Batched DoFn worker changes
> ----------------------------------------------------
>
>                 Key: BEAM-14481
>                 URL: https://issues.apache.org/jira/browse/BEAM-14481
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Brian Hulette
>            Priority: P1
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We've observed some OOMs in internal pipelines. We've narrowed the root cause 
> down to [https://github.com/apache/beam/pull/17384] - the worker changes for 
> Batched DoFns.
> I still don't understand the root cause, but given this change can lead to a 
> regression in pipelines that don't use the feature I think we should roll it 
> back.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to