[ 
https://issues.apache.org/jira/browse/BEAM-14481?focusedWorklogId=774193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774193
 ]

ASF GitHub Bot logged work on BEAM-14481:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/May/22 19:23
            Start Date: 24/May/22 19:23
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] commented on PR #17737:
URL: https://github.com/apache/beam/pull/17737#issuecomment-1136344881

   # 
[Codecov](https://codecov.io/gh/apache/beam/pull/17737?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#17737](https://codecov.io/gh/apache/beam/pull/17737?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (d9436c4) into 
[master](https://codecov.io/gh/apache/beam/commit/aea7c135a8e4c0189a1685ad8c2a132200e3bbd0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (aea7c13) will **increase** coverage by `0.00%`.
   > The diff coverage is `44.15%`.
   
   > :exclamation: Current head d9436c4 differs from pull request most recent 
head f19460f. Consider uploading reports for the commit f19460f to get more 
accurate results
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #17737   +/-   ##
   =======================================
     Coverage   73.99%   74.00%           
   =======================================
     Files         696      695    -1     
     Lines       91833    91798   -35     
   =======================================
   - Hits        67953    67931   -22     
   + Misses      22630    22621    -9     
   + Partials     1250     1246    -4     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | go | `50.44% <44.15%> (-0.02%)` | :arrow_down: |
   | python | `83.73% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/17737?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[sdks/go/pkg/beam/io/textio/textio.go](https://codecov.io/gh/apache/beam/pull/17737/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby90ZXh0aW8vdGV4dGlvLmdv)
 | `55.15% <44.15%> (-10.42%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/internal/gcp/auth.py](https://codecov.io/gh/apache/beam/pull/17737/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvZ2NwL2F1dGgucHk=)
 | `73.33% <0.00%> (-5.34%)` | :arrow_down: |
   | 
[...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/17737/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==)
 | `93.28% <0.00%> (-0.75%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/17737/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5)
 | `96.06% <0.00%> (-0.16%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/17737/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5)
 | `65.10% <0.00%> (+0.11%)` | :arrow_up: |
   | 
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/17737/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
 | `93.68% <0.00%> (+0.12%)` | :arrow_up: |
   | 
[sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/17737/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=)
 | `93.43% <0.00%> (+0.38%)` | :arrow_up: |
   | 
[...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/17737/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==)
 | `79.71% <0.00%> (+1.44%)` | :arrow_up: |
   | 
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/17737/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
 | `97.56% <0.00%> (+2.43%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/17737?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/17737?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[aea7c13...f19460f](https://codecov.io/gh/apache/beam/pull/17737?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 774193)
    Time Spent: 1.5h  (was: 1h 20m)

> OOM regression caused by Batched DoFn worker changes
> ----------------------------------------------------
>
>                 Key: BEAM-14481
>                 URL: https://issues.apache.org/jira/browse/BEAM-14481
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Brian Hulette
>            Priority: P1
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> We've observed some OOMs in internal pipelines. We've narrowed the root cause 
> down to [https://github.com/apache/beam/pull/17384] - the worker changes for 
> Batched DoFns.
> I still don't understand the root cause, but given this change can lead to a 
> regression in pipelines that don't use the feature I think we should roll it 
> back.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to