[
https://issues.apache.org/jira/browse/BEAM-14487?focusedWorklogId=772261&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772261
]
ASF GitHub Bot logged work on BEAM-14487:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/22 05:28
Start Date: 19/May/22 05:28
Worklog Time Spent: 10m
Work Description: lostluck opened a new pull request, #17710:
URL: https://github.com/apache/beam/pull/17710
Add drained and updated to states the Dataflow runner package is aware of in
the WaitForCompletion loop, and log and terminate appropriately. Make the
handling more consistent between states.
Tested manually against Dataflow.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 772261)
Remaining Estimate: 0h
Time Spent: 10m
> Make Drain a terminal state.
> ----------------------------
>
> Key: BEAM-14487
> URL: https://issues.apache.org/jira/browse/BEAM-14487
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Until recently, there have been no unbounded PCollections in the Go SDK, and
> only Dataflow supports drain.
> Either way, drain is a terminal state, and should cause any monitoring
> program to halt, rather query perpetually.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
