[
https://issues.apache.org/jira/browse/BEAM-14487?focusedWorklogId=772262&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772262
]
ASF GitHub Bot logged work on BEAM-14487:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/22 05:30
Start Date: 19/May/22 05:30
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on PR #17710:
URL: https://github.com/apache/beam/pull/17710#issuecomment-1131221492
#
[Codecov](https://codecov.io/gh/apache/beam/pull/17710?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#17710](https://codecov.io/gh/apache/beam/pull/17710?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(625a4e2) into
[master](https://codecov.io/gh/apache/beam/commit/6774b747ba42fdc187d4ba8dc34f48a3e1cc9368?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(6774b74) will **increase** coverage by `0.00%`.
> The diff coverage is `76.92%`.
```diff
@@ Coverage Diff @@
## master #17710 +/- ##
=======================================
Coverage 74.00% 74.01%
=======================================
Files 695 695
Lines 91798 91813 +15
=======================================
+ Hits 67938 67958 +20
+ Misses 22612 22607 -5
Partials 1248 1248
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `50.46% <76.92%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/17710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...ks/go/pkg/beam/runners/dataflow/dataflowlib/job.go](https://codecov.io/gh/apache/beam/pull/17710/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93bGliL2pvYi5nbw==)
| `22.84% <76.92%> (+6.57%)` | :arrow_up: |
|
[...o/pkg/beam/io/rtrackers/offsetrange/offsetrange.go](https://codecov.io/gh/apache/beam/pull/17710/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9ydHJhY2tlcnMvb2Zmc2V0cmFuZ2Uvb2Zmc2V0cmFuZ2UuZ28=)
| `75.70% <0.00%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/17710?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/17710?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[6774b74...625a4e2](https://codecov.io/gh/apache/beam/pull/17710?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 772262)
Time Spent: 20m (was: 10m)
> Make Drain a terminal state.
> ----------------------------
>
> Key: BEAM-14487
> URL: https://issues.apache.org/jira/browse/BEAM-14487
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Until recently, there have been no unbounded PCollections in the Go SDK, and
> only Dataflow supports drain.
> Either way, drain is a terminal state, and should cause any monitoring
> program to halt, rather query perpetually.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
