[
https://issues.apache.org/jira/browse/BEAM-14509?focusedWorklogId=774508&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774508
]
ASF GitHub Bot logged work on BEAM-14509:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/22 11:54
Start Date: 25/May/22 11:54
Worklog Time Spent: 10m
Work Description: damccorm opened a new pull request, #17752:
URL: https://github.com/apache/beam/pull/17752
This adds some of the missing flags from
https://cloud.google.com/dataflow/docs/reference/pipeline-options to the Go Sdk.
The diff is rough in places because of indentation, but the flags added are:
- dataflow_service_options
- number_of_worker_harness_threads
- dataflow_kms_key
- flexrs_goal
- enable_hot_key_logging
I tried running a pipeline with each of these enabled, though I wasn't able
to validate behavior for most because they're not totally visible behavior
changes, or they require pretty complex and/or expensive setups to notice a
difference.
Notably, this PR doesn't include the following flags which are included on
that page:
- worker_disk_type - already exists on the Go Sdk as disk_type (but is
currently not documented)
- update - Jack has a PR for this in flight - #17747
- create_from_snapshot - this flag is not useful until we support state
- sdk_location - this is currently a python only option which I don't think
we can just get for free. Additional investigation would be needed for this one.
- enable_streaming_engine - I tried this (it should control some
experiments), and we don't get it for free with the Go Sdk - we'd have to
follow up with the Dataflow team to figure out what it takes to turn streaming
engine on for the Go Sdk.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 774508)
Remaining Estimate: 0h
Time Spent: 10m
> Add Dataflow flags to Go
> ------------------------
>
> Key: BEAM-14509
> URL: https://issues.apache.org/jira/browse/BEAM-14509
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow, sdk-go
> Reporter: Danny McCormick
> Assignee: Danny McCormick
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
