[ 
https://issues.apache.org/jira/browse/BEAM-7015?focusedWorklogId=229316&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229316
 ]

ASF GitHub Bot logged work on BEAM-7015:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Apr/19 20:06
            Start Date: 17/Apr/19 20:06
    Worklog Time Spent: 10m 
      Work Description: aaltay commented on issue #8319: [BEAM-7015] Remove 
duplicate standard_coders.yaml
URL: https://github.com/apache/beam/pull/8319#issuecomment-484241128
 
 
   This 
(https://github.com/apache/beam/blob/35e3fa34a5e7321c7968b6790310fa20ce776afb/sdks/python/setup.py#L188)
 needs to be updated, otherwise setup.py would not package all the files 
correctly. This will manifest if someone takes the source code distribution of 
python sdk and tries to run tests on it (out of git code tree).
   
   We might be able to use gradle to copy this file in this location in a way 
to keep a single copy of the file. (I believe this might be akin to how proto 
files are generated from a shared source but they end up in python source tree.)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 229316)
    Time Spent: 1h 20m  (was: 1h 10m)

> Have only a single definition of standard_coders.yaml
> -----------------------------------------------------
>
>                 Key: BEAM-7015
>                 URL: https://issues.apache.org/jira/browse/BEAM-7015
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model, sdk-py-core
>            Reporter: Luke Cwik
>            Assignee: Thomas Weise
>            Priority: Major
>              Labels: portability, triaged
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> There are two copies of standard_coders.yaml defined:
> * 
> https://github.com/apache/beam/blob/master/model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml
> * 
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/testing/data/standard_coders.yaml
> The Python SDK specific instance should be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to