[
https://issues.apache.org/jira/browse/BEAM-7015?focusedWorklogId=232245&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-232245
]
ASF GitHub Bot logged work on BEAM-7015:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/19 17:25
Start Date: 24/Apr/19 17:25
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #8319: [BEAM-7015]
Remove duplicate standard_coders.yaml
URL: https://github.com/apache/beam/pull/8319#discussion_r278235195
##########
File path: sdks/python/setup.py
##########
@@ -185,7 +185,8 @@ def run(self):
author_email=PACKAGE_EMAIL,
packages=setuptools.find_packages(),
package_data={'apache_beam': [
- '*/*.pyx', '*/*/*.pyx', '*/*.pxd', '*/*/*.pxd',
'testing/data/*.yaml']},
+ '*/*.pyx', '*/*/*.pyx', '*/*.pxd', '*/*/*.pxd',
+ 'portability/api/*.yaml']},
Review comment:
We still need to keep `'testing/data/*.yaml'` in addition to the new
location because there is also another yaml file in the testing location (i.e.
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/testing/data/trigger_transcripts.yaml)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 232245)
Time Spent: 1h 40m (was: 1.5h)
> Have only a single definition of standard_coders.yaml
> -----------------------------------------------------
>
> Key: BEAM-7015
> URL: https://issues.apache.org/jira/browse/BEAM-7015
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-py-core
> Reporter: Luke Cwik
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability, triaged
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> There are two copies of standard_coders.yaml defined:
> *
> https://github.com/apache/beam/blob/master/model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml
> *
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/testing/data/standard_coders.yaml
> The Python SDK specific instance should be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
