[
https://issues.apache.org/jira/browse/BEAM-14504?focusedWorklogId=775549&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775549
]
ASF GitHub Bot logged work on BEAM-14504:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/22 18:12
Start Date: 27/May/22 18:12
Worklog Time Spent: 10m
Work Description: msbukal commented on code in PR #17741:
URL: https://github.com/apache/beam/pull/17741#discussion_r883859096
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java:
##########
@@ -1349,7 +1376,15 @@ public enum ContentStructure {
}
/** The type Execute bundles. */
- public static class ExecuteBundles extends Write {
+ public static class ExecuteBundles
+ extends PTransform<PCollection<FhirBundleParameter>,
ExecuteBundlesResult> {
+
+ /** The TupleTag used for bundles that were executed successfully. */
+ public static final TupleTag<FhirBundleResponse> SUCCESSFUL_BUNDLES = new
TupleTag<>();
+
+ /** The TupleTag used for bundles that failed to be executed for any
reason. */
+ public static final TupleTag<HealthcareIOError<FhirBundleResponse>>
FAILED_BUNDLES =
Review Comment:
I'd keep the HealthcareIOError as `HealthcareIOError<FhirBundleParameter>`
since you aren't adding a response to the FhirBundleResponse, so a user might
be confused why the response field is empty.
Issue Time Tracking
-------------------
Worklog Id: (was: 775549)
Time Spent: 3h (was: 2h 50m)
> Add support for including addittional parameters to executebundle method in
> fhirio.
> -----------------------------------------------------------------------------------
>
> Key: BEAM-14504
> URL: https://issues.apache.org/jira/browse/BEAM-14504
> Project: Beam
> Issue Type: Improvement
> Components: io-java-healthcare
> Reporter: Fathima Mohammed
> Assignee: Fathima Mohammed
> Priority: P2
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Add FhirBundleWithMetadata in executebundles method so that we can pass
> additional information like message id.
> FhirBundleWithMetadata represents a FHIR bundle, with it's metadata (eg. Hl7
> messageId) to be executed on the intermediate FHIR store.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
