[
https://issues.apache.org/jira/browse/BEAM-14504?focusedWorklogId=775575&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775575
]
ASF GitHub Bot logged work on BEAM-14504:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/22 20:16
Start Date: 27/May/22 20:16
Worklog Time Spent: 10m
Work Description: fbeevikm commented on code in PR #17741:
URL: https://github.com/apache/beam/pull/17741#discussion_r883954504
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleResponse.java:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.healthcare;
+
+import com.google.auto.value.AutoValue;
+import java.util.Objects;
+import javax.annotation.Nullable;
+
+@AutoValue
+public abstract class FhirBundleResponse {
+
+ static FhirBundleResponse.Builder builder() {
+ return new AutoValue_FhirBundleResponse.Builder();
+ }
+
+ /**
+ * String representing the metadata of the Bundle to be written. Used to
pass metadata through the
Review Comment:
done
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java:
##########
@@ -1349,7 +1376,15 @@ public enum ContentStructure {
}
/** The type Execute bundles. */
- public static class ExecuteBundles extends Write {
+ public static class ExecuteBundles
+ extends PTransform<PCollection<FhirBundleParameter>,
ExecuteBundlesResult> {
+
+ /** The TupleTag used for bundles that were executed successfully. */
+ public static final TupleTag<FhirBundleResponse> SUCCESSFUL_BUNDLES = new
TupleTag<>();
+
+ /** The TupleTag used for bundles that failed to be executed for any
reason. */
+ public static final TupleTag<HealthcareIOError<FhirBundleResponse>>
FAILED_BUNDLES =
Review Comment:
Done
Issue Time Tracking
-------------------
Worklog Id: (was: 775575)
Time Spent: 3h 40m (was: 3.5h)
> Add support for including addittional parameters to executebundle method in
> fhirio.
> -----------------------------------------------------------------------------------
>
> Key: BEAM-14504
> URL: https://issues.apache.org/jira/browse/BEAM-14504
> Project: Beam
> Issue Type: Improvement
> Components: io-java-healthcare
> Reporter: Fathima Mohammed
> Assignee: Fathima Mohammed
> Priority: P2
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Add FhirBundleWithMetadata in executebundles method so that we can pass
> additional information like message id.
> FhirBundleWithMetadata represents a FHIR bundle, with it's metadata (eg. Hl7
> messageId) to be executed on the intermediate FHIR store.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
