[
https://issues.apache.org/jira/browse/BEAM-14000?focusedWorklogId=775605&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775605
]
ASF GitHub Bot logged work on BEAM-14000:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/22 02:16
Start Date: 28/May/22 02:16
Worklog Time Spent: 10m
Work Description: aaltay commented on PR #17297:
URL: https://github.com/apache/beam/pull/17297#issuecomment-1140141428
> Thanks @nishantjain91 👍 @aaltay I'm actually stuck philosophically
regarding how to go about testing and what ought to be tested. I don't expect
that there should be tests across the codebase to ensure the correct usage of
other APIs and external modules nor their behaviour. Ex. it would be silly to
test the built-in Java addition operator.
>
> In the case covered by @nishantjain91's work, I suppose the most correct
way to test is by integration test against an ES cluster with certs. That just
strikes me as a lot of overhead for one use case. That said, if it happened to
be the most common use case, it would be well worth the overhead.
>
> Thoughts?
Integration tests for ES would probably be a reasonable option.
Issue Time Tracking
-------------------
Worklog Id: (was: 775605)
Time Spent: 3h 20m (was: 3h 10m)
> Elastic search IO doesnot work when both username/password and keystore are
> used
> --------------------------------------------------------------------------------
>
> Key: BEAM-14000
> URL: https://issues.apache.org/jira/browse/BEAM-14000
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: nishant jain
> Priority: P2
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> When using both username/password and ssl keystore, ElasticSearchIO doesnot
> Create correct restclient.
>
> Firstly, it sets HttpClientConfigCallback using httpAsyncClientBuilder if
> username and passowrd is used. Afterwards, it will replace
> HttpClientConfigCallback to httpClientBuilder is ssl store is used, hence
> losing the credentials provider
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
