[
https://issues.apache.org/jira/browse/BEAM-14000?focusedWorklogId=775947&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775947
]
ASF GitHub Bot logged work on BEAM-14000:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/22 14:59
Start Date: 30/May/22 14:59
Worklog Time Spent: 10m
Work Description: egalpin commented on PR #17297:
URL: https://github.com/apache/beam/pull/17297#issuecomment-1141253230
Thanks @aaltay 👍 I'd propose that we move forward with merging this code
as-is despite lack of test coverage at the moment, and separately track adding
test coverage[1]. Though I don't like that idea in general, the existing code
has no test coverage either (hence the need for this change now rather than
having caught the issue previously), and the changes in this PR represent a
net-positive change in functionality without regression of existing tests.
@nishantjain91 can you confirm whether username + password is used in any of
the tests?
Thoughts?
[1] https://issues.apache.org/jira/browse/BEAM-14531
Issue Time Tracking
-------------------
Worklog Id: (was: 775947)
Time Spent: 3.5h (was: 3h 20m)
> Elastic search IO doesnot work when both username/password and keystore are
> used
> --------------------------------------------------------------------------------
>
> Key: BEAM-14000
> URL: https://issues.apache.org/jira/browse/BEAM-14000
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: nishant jain
> Priority: P2
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> When using both username/password and ssl keystore, ElasticSearchIO doesnot
> Create correct restclient.
>
> Firstly, it sets HttpClientConfigCallback using httpAsyncClientBuilder if
> username and passowrd is used. Afterwards, it will replace
> HttpClientConfigCallback to httpClientBuilder is ssl store is used, hence
> losing the credentials provider
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
