[
https://issues.apache.org/jira/browse/BEAM-14553?focusedWorklogId=777830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777830
]
ASF GitHub Bot logged work on BEAM-14553:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/22 20:52
Start Date: 02/Jun/22 20:52
Worklog Time Spent: 10m
Work Description: kennknowles commented on code in PR #17818:
URL: https://github.com/apache/beam/pull/17818#discussion_r888403792
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java:
##########
@@ -1196,7 +1196,7 @@ public static <DestinationT>
FileResultCoder<DestinationT> of(
@Override
public List<? extends Coder<?>> getCoderArguments() {
- return Arrays.asList(windowCoder);
+ return Arrays.asList(windowCoder, destinationCoder);
Review Comment:
It seems to me that both versions are wrong and it should be
`ImmutableList.of(destinationCoder)`.
The javadoc:
```
/**
* If this is a {@link Coder} for a parameterized type, returns the list
of {@link Coder}s being
* used for each of the parameters in the same order they appear within
the parameterized type's
* type signature. If this cannot be done, or this {@link Coder} does not
encode/decode a
* parameterized type, returns the empty list.
*/
```
This means that since it is a `Coder<FileResult<DestinationT>>` that the
return value from `getCoderArguments` should line up with `DestinationT`.
Issue Time Tracking
-------------------
Worklog Id: (was: 777830)
Time Spent: 40m (was: 0.5h)
> Dataflow portable job submission translate FileResultCoder only with window
> coder
> ---------------------------------------------------------------------------------
>
> Key: BEAM-14553
> URL: https://issues.apache.org/jira/browse/BEAM-14553
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Yichi Zhang
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The destination coder is neglected, if there are multiple FileResultCoders
> with different destination coder, only first registration is successful.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
