[
https://issues.apache.org/jira/browse/BEAM-14553?focusedWorklogId=777840&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777840
]
ASF GitHub Bot logged work on BEAM-14553:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/22 21:20
Start Date: 02/Jun/22 21:20
Worklog Time Spent: 10m
Work Description: y1chi commented on code in PR #17818:
URL: https://github.com/apache/beam/pull/17818#discussion_r888423143
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java:
##########
@@ -1196,7 +1196,7 @@ public static <DestinationT>
FileResultCoder<DestinationT> of(
@Override
public List<? extends Coder<?>> getCoderArguments() {
- return Arrays.asList(windowCoder);
+ return Arrays.asList(windowCoder, destinationCoder);
Review Comment:
Should it be `FileResult<BoundedWindowT, DestinationT>` and the windowCoder
being `Coder<BoundedWindowT extends BoundedWindow>` Looking from the code it
think the window coder can change.
Issue Time Tracking
-------------------
Worklog Id: (was: 777840)
Time Spent: 1h (was: 50m)
> Dataflow portable job submission translate FileResultCoder only with window
> coder
> ---------------------------------------------------------------------------------
>
> Key: BEAM-14553
> URL: https://issues.apache.org/jira/browse/BEAM-14553
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Yichi Zhang
> Priority: P2
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The destination coder is neglected, if there are multiple FileResultCoders
> with different destination coder, only first registration is successful.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
