[
https://issues.apache.org/jira/browse/BEAM-14553?focusedWorklogId=778202&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778202
]
ASF GitHub Bot logged work on BEAM-14553:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jun/22 16:56
Start Date: 03/Jun/22 16:56
Worklog Time Spent: 10m
Work Description: y1chi commented on code in PR #17818:
URL: https://github.com/apache/beam/pull/17818#discussion_r889158954
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java:
##########
@@ -1196,7 +1196,7 @@ public static <DestinationT>
FileResultCoder<DestinationT> of(
@Override
public List<? extends Coder<?>> getCoderArguments() {
- return Arrays.asList(windowCoder);
+ return Arrays.asList(windowCoder, destinationCoder);
Review Comment:
So IIUC, the right thing to do is to have FileResult<WindowT, DestinationT>
so that coder inference can work for both window type and destination type. But
since all FileResult PCollections use explicit setCoders that's not a
requirement. I still think window coder needs to be in the components so that
FileResultCoder with different window coders won't collide with each other.
Issue Time Tracking
-------------------
Worklog Id: (was: 778202)
Time Spent: 2.5h (was: 2h 20m)
> Dataflow portable job submission translate FileResultCoder only with window
> coder
> ---------------------------------------------------------------------------------
>
> Key: BEAM-14553
> URL: https://issues.apache.org/jira/browse/BEAM-14553
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Yichi Zhang
> Priority: P2
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The destination coder is neglected, if there are multiple FileResultCoders
> with different destination coder, only first registration is successful.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
