[
https://issues.apache.org/jira/browse/BEAM-7087?focusedWorklogId=230342&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230342
]
ASF GitHub Bot logged work on BEAM-7087:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/19 00:36
Start Date: 20/Apr/19 00:36
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #8369: [BEAM-7087]
Creating "errors" package internal to Beam Go SDK
URL: https://github.com/apache/beam/pull/8369
I'm creating a package that prints well formatted errors for Beam. In
particular this package differentiates between context and error
messages and allows the top-level error message to be sent any time
in the chain of errors and still be the first error to display.
Note that this only adds the package, I will be converting existing
errors into this package in the future.
Example of an old error:
`creating new DoFn in scope root/CountWords: binding fn main.extractWordsFn:
binding params [{Value int}] to input string: string is not assignable to int`
New error:
```
string is not assignable to int
Caused by:
creating new DoFn in scope root/CountWords:
binding fn main.extractWordsFn:
binding params [{Value int}] to input string:
string is not assignable to int
```
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 230342)
Time Spent: 10m
Remaining Estimate: 0h
> Create an errors package for Go SDK
> -----------------------------------
>
> Key: BEAM-7087
> URL: https://issues.apache.org/jira/browse/BEAM-7087
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We can't import an established errors package such as github.com/pkg/errors
> due to how the Go SDK is currently implemented, so instead we should have our
> own package. This package should provide the following to be worth replacing
> the basic errors we currently use.
> # A way to wrap other errors without losing the original error, as in
> [https://github.com/pkg/errors]
> # Making printed errors more legible than currently. (For ex. having
> different wrapped errors on different lines, differentiating between errors
> and context, etc.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
