[
https://issues.apache.org/jira/browse/BEAM-7087?focusedWorklogId=233789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-233789
]
ASF GitHub Bot logged work on BEAM-7087:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/19 22:07
Start Date: 26/Apr/19 22:07
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #8406: [BEAM-7087]
Updating Go SDK errors in base beam directory
URL: https://github.com/apache/beam/pull/8406#discussion_r279117106
##########
File path: sdks/go/pkg/beam/combine.go
##########
@@ -54,25 +57,26 @@ func TryCombinePerKey(s Scope, combinefn interface{}, col
PCollection) (PCollect
ValidateKVType(col)
col, err := TryGroupByKey(s, col)
if err != nil {
- return PCollection{}, fmt.Errorf("failed to group by key: %v",
err)
+ return PCollection{}, addCombinePerKeyCtx(err, s)
Review comment:
Sorta. TryGroupByKey calls TryCoGroupByKey which adds "inserting
CoGroupByKey in scope %s". I figure the CoGroupByKey message is enough context
and we don't need another message mentioning the GroupByKey context, but if
differentiating the two is important it's easy to add that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 233789)
Time Spent: 1.5h (was: 1h 20m)
> Create an errors package for Go SDK
> -----------------------------------
>
> Key: BEAM-7087
> URL: https://issues.apache.org/jira/browse/BEAM-7087
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> We can't import an established errors package such as github.com/pkg/errors
> due to how the Go SDK is currently implemented, so instead we should have our
> own package. This package should provide the following to be worth replacing
> the basic errors we currently use.
> # A way to wrap other errors without losing the original error, as in
> [https://github.com/pkg/errors]
> # Making printed errors more legible than currently. (For ex. having
> different wrapped errors on different lines, differentiating between errors
> and context, etc.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
