[
https://issues.apache.org/jira/browse/BEAM-7029?focusedWorklogId=232914&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-232914
]
ASF GitHub Bot logged work on BEAM-7029:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/19 14:40
Start Date: 25/Apr/19 14:40
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #8322:
[BEAM-7029] Add KafkaIO.Write as an external transform
URL: https://github.com/apache/beam/pull/8322#discussion_r278579554
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -1325,12 +1325,89 @@ public void populateDisplayData(DisplayData.Builder
builder) {
abstract Builder<K, V> toBuilder();
@AutoValue.Builder
- abstract static class Builder<K, V> {
+ abstract static class Builder<K, V>
+ implements ExternalTransformBuilder<External.Configuration,
PCollection<KV<K, V>>, PDone> {
abstract Builder<K, V> setTopic(String topic);
abstract Builder<K, V> setWriteRecordsTransform(WriteRecords<K, V>
transform);
abstract Write<K, V> build();
+
+ @Override
+ public PTransform<PCollection<KV<K, V>>, PDone> buildExternal(
+ External.Configuration configuration) {
+ String topic = utf8String(configuration.topic);
+ setTopic(topic);
+
+ Map<String, Object> producerConfig = new HashMap<>();
+ for (KV<byte[], byte[]> kv : configuration.producerConfig) {
+ String key = utf8String(kv.getKey());
+ String value = utf8String(kv.getValue());
+ producerConfig.put(key, value);
+ }
+ Class keySerializer =
resolveClass(utf8String(configuration.keySerializer));
+ Class valSerializer =
resolveClass(utf8String(configuration.valueSerializer));
+
+ WriteRecords<K, V> writeRecords =
+ KafkaIO.<K, V>writeRecords()
+ .updateProducerProperties(producerConfig)
+ .withKeySerializer(keySerializer)
+ .withValueSerializer(valSerializer)
+ .withTopic(topic);
+ setWriteRecordsTransform(writeRecords);
+
+ return build();
+ }
+
+ private static Class resolveClass(String className) {
+ try {
+ return Class.forName(className);
+ } catch (ClassNotFoundException e) {
+ throw new RuntimeException("Could not find Serializer class: " +
className);
+ }
+ }
+
+ private static String utf8String(byte[] bytes) {
Review comment:
We have the same method for Read transform. Do we have similar function in
any utils class already? If not, it'd make sense to put it into
`org.apache.beam.sdk.util.StringUtils` to avoid code duplication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 232914)
Time Spent: 11.5h (was: 11h 20m)
> Support KafkaIO to be configured externally for use with other SDKs
> -------------------------------------------------------------------
>
> Key: BEAM-7029
> URL: https://issues.apache.org/jira/browse/BEAM-7029
> Project: Beam
> Issue Type: New Feature
> Components: io-java-kafka, runner-flink, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> As of BEAM-6730, we can externally configure existing transforms from SDKs.
> We should add more useful transforms then just {{GenerateSequence}}.
> {{KafkaIO}} is a good candidate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
