[
https://issues.apache.org/jira/browse/BEAM-7029?focusedWorklogId=232998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-232998
]
ASF GitHub Bot logged work on BEAM-7029:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/19 17:33
Start Date: 25/Apr/19 17:33
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8322: [BEAM-7029] Add
KafkaIO.Write as an external transform
URL: https://github.com/apache/beam/pull/8322#discussion_r278656442
##########
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##########
@@ -189,12 +190,28 @@ def test_external_transforms(self):
value_deserializer='org.apache.kafka.'
'common.serialization.'
'LongDeserializer',
- expansion_service=expansion_address))
+ expansion_service=get_expansion_service()))
self.assertTrue('No resolvable bootstrap urls given in bootstrap.servers'
in str(ctx.exception),
'Expected to fail due to invalid bootstrap.servers, but '
'failed due to:\n%s' % str(ctx.exception))
+ # We just test the expansion but do not execute.
Review comment:
Yes, I saw the PR (#8397). That will be great to extend our test coverage
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 232998)
Time Spent: 12.5h (was: 12h 20m)
> Support KafkaIO to be configured externally for use with other SDKs
> -------------------------------------------------------------------
>
> Key: BEAM-7029
> URL: https://issues.apache.org/jira/browse/BEAM-7029
> Project: Beam
> Issue Type: New Feature
> Components: io-java-kafka, runner-flink, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 12.5h
> Remaining Estimate: 0h
>
> As of BEAM-6730, we can externally configure existing transforms from SDKs.
> We should add more useful transforms then just {{GenerateSequence}}.
> {{KafkaIO}} is a good candidate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
