[
https://issues.apache.org/jira/browse/BEAM-7166?focusedWorklogId=235513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235513
]
ASF GitHub Bot logged work on BEAM-7166:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Apr/19 19:56
Start Date: 30/Apr/19 19:56
Worklog Time Spent: 10m
Work Description: akedin commented on pull request #8421: [BEAM-7166] Add
more checks on join condition
URL: https://github.com/apache/beam/pull/8421#discussion_r279911473
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java
##########
@@ -566,7 +566,15 @@ private static Field getFieldBasedOnRexFieldAccess(
private Pair<RexNode, RexNode> extractJoinPairOfRexNodes(RexCall rexCall) {
if (!rexCall.getOperator().getName().equals("=")) {
- throw new UnsupportedOperationException("Non equi-join is not
supported!");
+ throw new UnsupportedOperationException("Non equi-join is not
supported");
+ }
+
+ if ((!(rexCall.getOperands().get(0) instanceof RexInputRef)
Review comment:
Can you wrap these conditions into methods like `isFieldOrInputRef()` with a
comment? Otherwise it's hard to read
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 235513)
Time Spent: 40m (was: 0.5h)
> Add more checks on join condition
> ---------------------------------
>
> Key: BEAM-7166
> URL: https://issues.apache.org/jira/browse/BEAM-7166
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Join should reject conditions that are not supported.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
