[
https://issues.apache.org/jira/browse/BEAM-7166?focusedWorklogId=235514&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235514
]
ASF GitHub Bot logged work on BEAM-7166:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Apr/19 19:59
Start Date: 30/Apr/19 19:59
Worklog Time Spent: 10m
Work Description: akedin commented on pull request #8421: [BEAM-7166] Add
more checks on join condition
URL: https://github.com/apache/beam/pull/8421#discussion_r279912390
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRelBoundedVsBoundedTest.java
##########
@@ -227,6 +229,68 @@ public void testException_nonEqualJoin() throws Exception
{
pipeline.run();
}
+ @Test
+ public void testException_join_condition1() throws Exception {
+ String sql =
+ "SELECT * "
+ + "FROM ORDER_DETAILS1 o1"
+ + " JOIN ORDER_DETAILS2 o2"
+ + " on "
+ + " o1.order_id = o2.site_id OR o1.price = o2.site_id";
+
+ thrown.expect(UnsupportedOperationException.class);
+ thrown.expectMessage("Operator OR is not supported in join condition");
Review comment:
I think general recommendation is not to compare the whole message, but
rather that it contains things. Otherwise it becomes too brittle and harder to
maintain. E.g. I think in this case it will be enough that it's an
`UnsupportedException` with a message that contains `"operator OR"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 235514)
Time Spent: 50m (was: 40m)
> Add more checks on join condition
> ---------------------------------
>
> Key: BEAM-7166
> URL: https://issues.apache.org/jira/browse/BEAM-7166
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Join should reject conditions that are not supported.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
