[
https://issues.apache.org/jira/browse/BEAM-5379?focusedWorklogId=236974&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-236974
]
ASF GitHub Bot logged work on BEAM-5379:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/19 18:09
Start Date: 03/May/19 18:09
Worklog Time Spent: 10m
Work Description: lostluck commented on issue #8354: [BEAM-5379] Go
Modules versioning support
URL: https://github.com/apache/beam/pull/8354#issuecomment-489189124
I do believe that even generated files need the license comment.
Turns out resolving this versioning thing in some capacity will help solve
an issue around generating the go versions of protos too. There's currently
lots of churn since the versions of protoc-gen-go and the go proto
implementation will change with every new person adding protos, since those
versions aren't locked presently (but should be).
Have you made additional headway on this in the meantime? At this point the
temporary 2 lockfile state is probably preferable, and easier to handle than
the "no one can meaningfully update Go protos" state we're currently in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 236974)
Time Spent: 2h 10m (was: 2h)
> Go Modules versioning support
> -----------------------------
>
> Key: BEAM-5379
> URL: https://issues.apache.org/jira/browse/BEAM-5379
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> This would make it easier for non-Go developers to update and test changes to
> the Go SDK without jumping through hoops to set up Go Paths at first.
> Right now, we us the gogradle plugin for gradle to handle re-producible
> builds. Without doing something with the GO_PATH relative to a user's local
> git repo though, changes made in the user's repo are not represented when
> gradle is invoked to test everything.
> One of at least the following needs to be accomplished:
> * gogradle moves to support the Go Modules experiment in Go 1.11, and the SDK
> migrates to that
> * or we re-implement our gradle go rules ourselves to use them,
> * or some third option, that moves away from the GO_PATH nit.
> This issue should be resolved after deciding and implementing a clear
> versioning story for the SDK, ideally along Go best practices.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
