[
https://issues.apache.org/jira/browse/BEAM-5379?focusedWorklogId=237083&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237083
]
ASF GitHub Bot logged work on BEAM-5379:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/19 22:08
Start Date: 03/May/19 22:08
Worklog Time Spent: 10m
Work Description: lostluck commented on issue #8354: [BEAM-5379] Go
Modules versioning support
URL: https://github.com/apache/beam/pull/8354#issuecomment-489255160
Ah! No worries. Life/Family >>> code!
That matches my understanding as well. Python requires a whole virtual
environment set up to ensure hermetic builds while Go Modules handle that
in the tools without additional installations. We shouldn't need worry
about clearing the Jenkins machines versioning caches, since Go should be
able to manage that efficiently for us.
I just checked with Yifan who recently handled the Jenkins machine update:
Each of the languages handles their own integration test set up
independently.
In short, if we can address the issues observed by Python's set up, we
should be golden.
On Fri, May 3, 2019, 2:01 PM Nathan Fisher <[email protected]> wrote:
> Had family in town so doing the royal tour so to speak. Likely to look at
> it Sunday evening. Want to map out all of the concerns including those
> outlined in the email. It feels some of the concerns raised are more in
> direct relation to the python build is that a correct understanding? Or is
> python used for integration tests across all language SDKs?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/8354#issuecomment-489238565>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/ADKDOFMNGHVJBE5FHAJDUC3PTSR2DANCNFSM4HHB7MGQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 237083)
Time Spent: 2.5h (was: 2h 20m)
> Go Modules versioning support
> -----------------------------
>
> Key: BEAM-5379
> URL: https://issues.apache.org/jira/browse/BEAM-5379
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> This would make it easier for non-Go developers to update and test changes to
> the Go SDK without jumping through hoops to set up Go Paths at first.
> Right now, we us the gogradle plugin for gradle to handle re-producible
> builds. Without doing something with the GO_PATH relative to a user's local
> git repo though, changes made in the user's repo are not represented when
> gradle is invoked to test everything.
> One of at least the following needs to be accomplished:
> * gogradle moves to support the Go Modules experiment in Go 1.11, and the SDK
> migrates to that
> * or we re-implement our gradle go rules ourselves to use them,
> * or some third option, that moves away from the GO_PATH nit.
> This issue should be resolved after deciding and implementing a clear
> versioning story for the SDK, ideally along Go best practices.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
