[
https://issues.apache.org/jira/browse/BEAM-7238?focusedWorklogId=239291&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-239291
]
ASF GitHub Bot logged work on BEAM-7238:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/19 16:31
Start Date: 08/May/19 16:31
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8515: [BEAM-7238]
Make sfl4j bindings runtimeOnly/testRuntimeOnly
URL: https://github.com/apache/beam/pull/8515#discussion_r282147401
##########
File path: runners/core-java/build.gradle
##########
@@ -45,6 +45,6 @@ dependencies {
shadowTest library.java.mockito_core
shadowTest library.java.junit
shadowTest library.java.slf4j_api
- shadowTest library.java.slf4j_simple
shadowTest library.java.jackson_dataformat_yaml
+ testRuntimeOnly library.java.slf4j_simple
Review comment:
Yes, modules that set testShadowJar will run their unit tests using the
shaded jars
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 239291)
Time Spent: 10m
Remaining Estimate: 0h
> Make sfl4j bindings runtimeOnly/testRuntimeOnly
> -----------------------------------------------
>
> Key: BEAM-7238
> URL: https://issues.apache.org/jira/browse/BEAM-7238
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Multiple modules are including sfl4j bindings in the compile or testCompile
> scope this is an issue because this may break loggin in particular in logs
> that are reused by others. Concrete case sfl4j-simple runners-core and the
> logging in the specific runners.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
