[
https://issues.apache.org/jira/browse/BEAM-7238?focusedWorklogId=239347&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-239347
]
ASF GitHub Bot logged work on BEAM-7238:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/19 17:54
Start Date: 08/May/19 17:54
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #8515: [BEAM-7238]
Make sfl4j bindings runtimeOnly/testRuntimeOnly
URL: https://github.com/apache/beam/pull/8515#discussion_r282178669
##########
File path: runners/samza/job-server/build.gradle
##########
@@ -24,18 +24,19 @@ apply plugin: 'application'
mainClassName = "org.apache.beam.runners.samza.SamzaJobServerDriver"
applyJavaNature(
- validateShadowJar: false,
- exportJavadoc: false,
- shadowClosure: {
- append "reference.conf"
- },
+ validateShadowJar: false,
+ testShadowJar: true,
+ exportJavadoc: false,
+ shadowClosure: {
+ append "reference.conf"
+ },
)
dependencies {
compile project(path: ":beam-runners-samza", configuration: "shadow")
compile group: "org.slf4j", name: "jcl-over-slf4j", version:
dependencies.create(project.library.java.slf4j_api).getVersion()
- compile library.java.slf4j_simple
shadow library.java.guava
+ shadowTestRuntimeClasspath library.java.slf4j_simple
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 239347)
Time Spent: 50m (was: 40m)
> Make sfl4j bindings runtimeOnly/testRuntimeOnly
> -----------------------------------------------
>
> Key: BEAM-7238
> URL: https://issues.apache.org/jira/browse/BEAM-7238
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Multiple modules are including sfl4j bindings in the compile or testCompile
> scope this is an issue because this may break loggin in particular in logs
> that are reused by others. Concrete case sfl4j-simple runners-core and the
> logging in the specific runners.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
