[ https://issues.apache.org/jira/browse/BEAM-7269?focusedWorklogId=240432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240432 ]
ASF GitHub Bot logged work on BEAM-7269: ---------------------------------------- Author: ASF GitHub Bot Created on: 10/May/19 21:41 Start Date: 10/May/19 21:41 Worklog Time Spent: 10m Work Description: je-ik commented on issue #8555: [BEAM-7269] remove StateSpec from hashCode of SimpleStateTag URL: https://github.com/apache/beam/pull/8555#issuecomment-491438335 Oops, I thought I have run the tests, but apparently I haven't. :-) Fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 240432) Time Spent: 0.5h (was: 20m) > Remove StateSpec from hashCode of SimpleStateTag > ------------------------------------------------ > > Key: BEAM-7269 > URL: https://issues.apache.org/jira/browse/BEAM-7269 > Project: Beam > Issue Type: Bug > Components: runner-core > Affects Versions: 2.12.0 > Reporter: Jan Lukavský > Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > SimpleStateTag is used as key in hash based StateTable, and currently is > hashes and compares StateSpec and StructuredId, that are inside the > SimpleStateTag. StateSpec hashes Coder into the resulting hashCode and when > the Coder fails to have a proper hashCode and equals implementations, it > results in wrong behavior (apparently missing states). -- This message was sent by Atlassian JIRA (v7.6.3#76005)