[
https://issues.apache.org/jira/browse/BEAM-7269?focusedWorklogId=241220&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241220
]
ASF GitHub Bot logged work on BEAM-7269:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/19 18:23
Start Date: 13/May/19 18:23
Worklog Time Spent: 10m
Work Description: je-ik commented on issue #8555: [BEAM-7269] remove
StateSpec from hashCode of SimpleStateTag
URL: https://github.com/apache/beam/pull/8555#issuecomment-491932834
Sure, that was exactly how I understood it, but my point was that that's
exactly the way HashMap and HashSet work, so that probably won't be any
surprise to Java developers. Although a simple fix would probably be to use
coder and store serialized key wrapped in ByteBuffer or something similar.
Question is if it is "worth it", because as noted previously, there will
probably not be many people storing byte arrays as keys. Just my 2 cents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 241220)
Time Spent: 1h 40m (was: 1.5h)
> Remove StateSpec from hashCode of SimpleStateTag
> ------------------------------------------------
>
> Key: BEAM-7269
> URL: https://issues.apache.org/jira/browse/BEAM-7269
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Affects Versions: 2.12.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavsky
> Priority: Major
> Fix For: 2.14.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> SimpleStateTag is used as key in hash based StateTable, and currently is
> hashes and compares StateSpec and StructuredId, that are inside the
> SimpleStateTag. StateSpec hashes Coder into the resulting hashCode and when
> the Coder fails to have a proper hashCode and equals implementations, it
> results in wrong behavior (apparently missing states).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
