[
https://issues.apache.org/jira/browse/BEAM-7356?focusedWorklogId=245464&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245464
]
ASF GitHub Bot logged work on BEAM-7356:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/19 19:11
Start Date: 20/May/19 19:11
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #8613: [BEAM-7356] Support
generic field selections in Filter.
URL: https://github.com/apache/beam/pull/8613#issuecomment-494114370
"generic" in the PR title meant generic field access strings. This PR
allows passing "x.y.z" into filter to filter on subfields, while the
previous Filter using did not allow this.
I made one change to actual Java generics, to make the transform better
able to infer types from lambdas. Previously you had to cast the type
inside your lambda, and now that is not necessary.
Good point on confusing names. I'll try and fix those.
On Mon, May 20, 2019 at 11:55 AM Yueyang Qiu <[email protected]>
wrote:
> *@robinyqiu* approved this pull request.
>
> LGTM. But I have a question: why do we need generics in field selection?
> i.e. why is this implementation better than the previous one using maps?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/8613?email_source=notifications&email_token=AFAYJVKKYFDI2A4WGJM62D3PWLXZBA5CNFSM4HN23YD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZEQ46Q#pullrequestreview-239668858>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AFAYJVP7X2CCTJUPZD4SZ33PWLXZBANCNFSM4HN23YDQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 245464)
Time Spent: 1h (was: 50m)
> Select should support nested schema selectors
> ---------------------------------------------
>
> Key: BEAM-7356
> URL: https://issues.apache.org/jira/browse/BEAM-7356
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
