[
https://issues.apache.org/jira/browse/BEAM-7356?focusedWorklogId=247196&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-247196
]
ASF GitHub Bot logged work on BEAM-7356:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/19 00:34
Start Date: 23/May/19 00:34
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #8613: [BEAM-7356]
Support generic field selections in Filter.
URL: https://github.com/apache/beam/pull/8613#discussion_r286737920
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Filter.java
##########
@@ -84,95 +87,128 @@
/** Implementation of the filter. */
public static class Inner<T> extends PTransform<PCollection<T>,
PCollection<T>> {
- private final Map<String, SerializableFunction<?, Boolean>>
fieldNameFilters =
- Maps.newHashMap();
- private final Map<Integer, SerializableFunction<?, Boolean>>
fieldIdFilters = Maps.newHashMap();
- private final Map<List<String>, SerializableFunction<Row, Boolean>>
fieldNamesFilters =
- Maps.newHashMap();
- private final Map<List<Integer>, SerializableFunction<Row, Boolean>>
fieldIdsFilters =
- Maps.newHashMap();
+ @AutoValue
+ abstract static class FilterDescription<FieldT> implements Serializable {
+ abstract FieldAccessDescriptor getFieldAccessDescriptor();
+
+ abstract SerializableFunction<FieldT, Boolean> getPredicate();
+
+ @Nullable
+ abstract Schema getOutputSchema();
+
+ abstract boolean getUnbox();
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 247196)
Time Spent: 1.5h (was: 1h 20m)
> Select should support nested schema selectors
> ---------------------------------------------
>
> Key: BEAM-7356
> URL: https://issues.apache.org/jira/browse/BEAM-7356
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
