[
https://issues.apache.org/jira/browse/BEAM-7366?focusedWorklogId=246406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-246406
]
ASF GitHub Bot logged work on BEAM-7366:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/19 21:54
Start Date: 21/May/19 21:54
Worklog Time Spent: 10m
Work Description: adude3141 commented on issue #8624: [BEAM-7366]
Determine Spotless target based on project's SourceSet
URL: https://github.com/apache/beam/pull/8624#issuecomment-494572521
Sorry for the delay.
Unfortunately I am a bit confused currently. Executing
```
./gradlew clean build -p sdks/java/core/
```
fails on my machine now with spotless complaining about the antlr generated
files. Which I honestly do not understand, as those files did not show up
during diffing.
So we might need to keep the exclusion filter anyway and change the
implementation to something like
```
def union = project.files([]).asFileTree
project.sourceSets.each { sourceset -> union += sourceset.allJava }
target union.matching {
include '**/*.java'
exclude '**/archetype-resources/src/**'
exclude '**/build/generated/**'
//exclude '**/build/resources/**'
exclude '**/build/generated-src/**'
exclude '**/build/generated-*-avro-*/**'
}.files
```
This will consider only those files from the source sets. To add a 'catch
all' as implemented before, we might change the first line to
```
def union = project.fileTree(project.projectDir)
```
and probably add the 'build/resources' exclusion shown above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 246406)
Time Spent: 3h 40m (was: 3.5h)
> Spotless task does not run
> --------------------------
>
> Key: BEAM-7366
> URL: https://issues.apache.org/jira/browse/BEAM-7366
> Project: Beam
> Issue Type: Bug
> Components: build-system, runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Critical
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Somehow spotless is not active anymore. No errors are reported, no
> auto-formatting can be applied. Need to investigate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
