[
https://issues.apache.org/jira/browse/BEAM-7084?focusedWorklogId=246786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-246786
]
ASF GitHub Bot logged work on BEAM-7084:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/19 14:51
Start Date: 22/May/19 14:51
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8639: [BEAM-7084] Allow
custom environments for external transforms
URL: https://github.com/apache/beam/pull/8639#discussion_r286532871
##########
File path: model/job-management/src/main/proto/beam_expansion_api.proto
##########
@@ -46,6 +46,9 @@ message ExpansionRequest {
// A namespace (prefix) to use for the id of any newly created
// components.
string namespace = 3;
+
+ // The type of environment to use for the expanded transform.
+ org.apache.beam.model.pipeline.v1.Environment environment = 4;
Review comment:
Completely agree, makes sense to add the environments to components.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 246786)
Time Spent: 2h 20m (was: 2h 10m)
> Support custom environment types when expanding external transforms
> -------------------------------------------------------------------
>
> Key: BEAM-7084
> URL: https://issues.apache.org/jira/browse/BEAM-7084
> Project: Beam
> Issue Type: Bug
> Components: beam-model, sdk-java-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The {{ExpansionService}} registers a default Docker JAVA SDK environment.
> Users should be able to specify other types of environment, i.e.
> Process/External/Embedded.
> We can add an {{environment_type}} field to the {{ExpansionRequest}} Proto
> message.
> CC [~robertwb]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
