[
https://issues.apache.org/jira/browse/BEAM-6356?focusedWorklogId=248384&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-248384
]
ASF GitHub Bot logged work on BEAM-6356:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/19 02:24
Start Date: 25/May/19 02:24
Worklog Time Spent: 10m
Work Description: ostrokach commented on pull request #8687: [BEAM-6356]
Add the option to use TFRecord to store cache results using PCollection's PCoder
URL: https://github.com/apache/beam/pull/8687
This is a continuation of apache/beam#8458, but instead of entirely
switching from Text to TFRecords for storing PCollection caches, we add the
*option* of using TFRecords, while keeping Text as the default storage format.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
R: @leo-unc @qinyeli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 248384)
Time Spent: 1h (was: 50m)
Remaining Estimate: 167h (was: 167h 10m)
> Python FileBasedCacheManager does not respect PCoder for PCollection being
> cached
> ----------------------------------------------------------------------------------
>
> Key: BEAM-6356
> URL: https://issues.apache.org/jira/browse/BEAM-6356
> Project: Beam
> Issue Type: Improvement
> Components: examples-python
> Reporter: Hennadiy Leontyev
> Assignee: Qinye Li
> Priority: Minor
> Original Estimate: 168h
> Time Spent: 1h
> Remaining Estimate: 167h
>
> FileBasedCacheManager used by Python's InteractiveRunner does not preserve
> PCoder for elements of a PCollection being cached on disk. I suggest that the
> cache on-disk format to be changed to TFRecords (which are supported by Beam)
> and FileBasedCacheManager would store the desired PCoder for cached
> collections.
> Currently, it is not possible to work with dynamically-generated protocol
> buffer messages in interactive runner mode because of pickling errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
